Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way resources yaml file is being loaded #106

Open
zroubalik opened this issue Aug 25, 2021 · 4 comments
Open

Change the way resources yaml file is being loaded #106

zroubalik opened this issue Aug 25, 2021 · 4 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@zroubalik
Copy link
Member

At the moment the resources file is being loaded into the operator during the startup:

resourcesManifest, err := resources.GetResourcesManifest()
if err != nil {
return err
}
manifestGeneral, manifestController, manifestMetrics, err := parseManifestsFromFile(resourcesManifest, r.Client)
if err != nil {
return err
}

It would be better to use go embed feature introduced in Go 1.16: https://golangtutorial.dev/tips/embed-files-in-go/

@zroubalik zroubalik added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 25, 2021
@husnialhamdani
Copy link
Contributor

Hi @zroubalik,
Can I work on this?

@zroubalik
Copy link
Member Author

@husnialhamdani absolutely, please coordinate with @joelsmith, he is the main point of contact for this repo.

@joelsmith
Copy link
Contributor

@husnialhamdani, that would be great, thanks! Let me know if you have any questions along the way

@husnialhamdani
Copy link
Contributor

@joelsmith @zroubalik Thanks for assigning,
want to confirm if my understanding correct,
So we have to change the way to load the resources with Go embed in this file ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants