Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py.typed marker file (as defined by PEP 561) #46

Merged
merged 2 commits into from May 19, 2022

Conversation

jonemo
Copy link
Contributor

@jonemo jonemo commented May 19, 2022

Addresses #45

Adds the py.typed file as per PEP 561. This ensures that projects that import InquirerPy can be type checked.

Copy link
Owner

@kazhala kazhala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this.

@kazhala kazhala merged commit e69ab82 into kazhala:master May 19, 2022
@jonemo
Copy link
Contributor Author

jonemo commented May 25, 2022

@kazhala Thanks for the quick merge!

Two followups:

  1. Can you close Missing py.typed marker file for PEP 561 #45 ? I don't seem to be able to do that myself.
  2. Merging my PR into master seems to have broken the pyright step of the CI pipeline in a major way. I am not quite sure how my change could cause these errors, can you take a look?

@kazhala
Copy link
Owner

kazhala commented May 25, 2022

Hi @jonemo ,

Thanks again for doing this. I should have touched up in the issue ticket for this. No not your changes broke the pyright lints, think pyright updated some checks around Optional[XXX] which I need to update the codebase to align with that.

I've been quite busy for the last few months and should have fixed the pyright thing first. I'll close your issue once I fix the linting and make a quick release.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants