Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker exec hang #6154

Closed
bergwolf opened this issue Jan 30, 2023 · 4 comments · Fixed by moby/moby#44888
Closed

docker exec hang #6154

bergwolf opened this issue Jan 30, 2023 · 4 comments · Fixed by moby/moby#44888
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
Issue backlog

Comments

@bergwolf
Copy link
Member

Reported by Jim Carroll from Mirantis:

terminal 1:
docker run --rm -it --name katatest --runtime io.containerd.kata.v2 alpine
terminal 2:
docker exec -it katatest /bin/sh
everything seems fine.
Until I try to exit the exec session, at which point the following happens:

  • the exec’d session hangs (tty is effectively frozen)
  • the original docker run session exits
  • docker ps shows that no containers are running

I have to kill the exec command still hung in terminal 2 to regain control of that lost soul
@bergwolf bergwolf added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Jan 30, 2023
bergwolf added a commit to bergwolf/kata-containers that referenced this issue Jan 30, 2023
@bergwolf
runtime/vc: return fake pid for exec process exit events
471927e 
We cannot return the container ID 'cause that can make moby think that
the container process itself exits. Let's return a fake pid 0 here.

Fixes: kata-containers#6154
Signed-off-by: Peng Tao <bergwolf@hyper.sh>
bergwolf added a commit to bergwolf/kata-containers that referenced this issue Jan 30, 2023
@bergwolf
runtime: return fake pid for exec process exit events
6baa90d 
We cannot return the container ID 'cause that can make moby think that
the container process itself exits. Let's return a fake pid 0 here.

Fixes: kata-containers#6154
Signed-off-by: Peng Tao <bergwolf@hyper.sh>
@bergwolf bergwolf mentioned this issue Jan 30, 2023
Closed
@katacontainersbot katacontainersbot moved this from To do to In progress in Issue backlog Jan 30, 2023
@corhere corhere mentioned this issue Jan 30, 2023
Merged
@liubin
Copy link
Member

liubin commented Jan 31, 2023

Should this be closed? @bergwolf

@corhere corhere mentioned this issue Jan 31, 2023
Merged
@neersighted
Copy link

Not until we merge the PR in Moby, in my opinion. It looks like GitHub has even set it up to auto-close.

@neersighted
Copy link

Looks like the auto-close doesn't work across orgs, despite the Web UI claiming so. Anyway, we've merged the fix for the Moby master branch, and the fix for 23.0 is in review for the next patch. I'd suggest this can be closed and those interested in the fixes can monitor the related PRs.

@bergwolf
Copy link
Member Author

bergwolf commented Jun 6, 2023

Thanks @neersighted ! Let's close this as moby/moby#44892 has been merged.

@bergwolf bergwolf closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
Issue backlog
  
In progress
Milestone
No milestone
3 participants
@bergwolf @neersighted @liubin