From e1c916d526c226c84b305093d6773cccdb3c2585 Mon Sep 17 00:00:00 2001 From: David Leger Date: Tue, 12 Sep 2017 23:32:57 -0300 Subject: [PATCH] Resolved issue #2971 (#2989) * Resolved issue #2971 - changed h2 to h1 in template to adhere to accessibility guidelines. - Added h1 styles to maintain same font size. * Added header tag to template Corrected templete to use semantically correct header tag for header instead of div * Added className for App-title - Added className="App-title" to h1 tag - Changed CSS selector to target class instead of element --- packages/react-scripts/template/src/App.css | 4 ++++ packages/react-scripts/template/src/App.js | 6 +++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/react-scripts/template/src/App.css b/packages/react-scripts/template/src/App.css index 15adfdc710c..c5c6e8a68ad 100644 --- a/packages/react-scripts/template/src/App.css +++ b/packages/react-scripts/template/src/App.css @@ -14,6 +14,10 @@ color: white; } +.App-title { + font-size: 1.5em; +} + .App-intro { font-size: large; } diff --git a/packages/react-scripts/template/src/App.js b/packages/react-scripts/template/src/App.js index d7d52a7f38a..203067e4d75 100644 --- a/packages/react-scripts/template/src/App.js +++ b/packages/react-scripts/template/src/App.js @@ -6,10 +6,10 @@ class App extends Component { render() { return (
-
+
logo -

Welcome to React

-
+

Welcome to React

+

To get started, edit src/App.js and save to reload.