Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cursor on every EditText #99

Merged
merged 6 commits into from Apr 22, 2020

Conversation

hamorillo
Copy link
Contributor

📌 References

🎩 What is the goal?

Remove cursor in all EditText before make the screenshot.

How is it being implemented?

Added method for searching all views that match a filter. In our case, we are going to use this method in ScreenshotTest interface in order to obtain all EditText in the tested views and hide their cursor before execute the screenshot.

Added method for search all views with a filter and using it for remove cursor in EditText
@pedrovgs pedrovgs self-requested a review April 13, 2020 06:04
Copy link
Owner

@pedrovgs pedrovgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this PR @hamorillo 😃 This was my next step for the issue #94. Before reviewing the code I'm wondering if you could perform two tasks we need in order to consider this PR as a valid PR:

  1. Point this branch at integrate-new-shot-android-module instead of master.
  2. Creat a new activity in the android project shot-consumer with an EditText inside and write an instrumentation test to ensure your feature is working.

Once this is done and the build is passing on CI, I'll personally review the code. Thank you in advance!

@hamorillo hamorillo changed the base branch from master to integrate-new-shot-android-module April 14, 2020 15:54
@hamorillo
Copy link
Contributor Author

@pedrovgs I've made both changes.

  • PR pointed to branch integrate-new-shot-android-module
  • Implemented new activity and it's test in order to test that the cursor is hided before the screenshot is made.

If you think there are more things I could improve in the PR just tell me.
Thanks!

Copy link
Owner

@pedrovgs pedrovgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just perfect!! I'll change the code a little bit in order to apply some renaming and change some methods visibility but it works and it's really helpful for us right now. I'd really like to thank you for you help @hamorillo This is going to be part of the next release I'm planning for today 😃

@pedrovgs pedrovgs merged commit 9b82ed2 into pedrovgs:integrate-new-shot-android-module Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants