New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable cursor on every EditText #99
Disable cursor on every EditText #99
Conversation
Added method for search all views with a filter and using it for remove cursor in EditText
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this PR @hamorillo 😃 This was my next step for the issue #94. Before reviewing the code I'm wondering if you could perform two tasks we need in order to consider this PR as a valid PR:
- Point this branch at
integrate-new-shot-android-module
instead of master. - Creat a new activity in the android project
shot-consumer
with anEditText
inside and write an instrumentation test to ensure your feature is working.
Once this is done and the build is passing on CI, I'll personally review the code. Thank you in advance!
…rate-new-shot-android-module
This activity will be used to test that shot-android disable cursor on edittext before make the screenshot.
@pedrovgs I've made both changes.
If you think there are more things I could improve in the PR just tell me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just perfect!! I'll change the code a little bit in order to apply some renaming and change some methods visibility but it works and it's really helpful for us right now. I'd really like to thank you for you help @hamorillo This is going to be part of the next release I'm planning for today 😃
📌 References
🎩 What is the goal?
Remove cursor in all
EditText
before make the screenshot.How is it being implemented?
Added method for searching all views that match a filter. In our case, we are going to use this method in
ScreenshotTest
interface in order to obtain all EditText in the tested views and hide their cursor before execute the screenshot.