-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ResourceInterpreterCustomization
for Prune
#4945
Comments
@a7i Thanks for your feedback, I think this is an interesting feature point. Before we start discussing how to do this, let's invite some ideas from people who might be interested in this. /cc @chaunceyjiang @whitewindmills @RainbowMango @yike21 @iawia002 |
Hi @a7i I'd like to know under what circumstances this would be necessary. Because after communicating with @RainbowMango, I realized that |
Prune would be to strip certain fields (e.g. label) from being propagated. With Retain, the label still goes to the member cluster but the value is essentially ignored. One use-case is that we use a label to determine if a workload should be duplicated in all member clusters or not (the label is matched by the policy labelSelector). There is no need for this label to get propagated to the member clusters. |
Thanks for the use case. I think it makes sense. |
It seems to make sense, I'll get back to it later. |
make sense. |
It seems a reasonable use case that you label resources and let PropagationPolicy match them.
|
🤔 It seems that using OverridePolicy can cove this. |
Using Lua gives more flexibility and control than /close |
@a7i: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Oh, seems you like Lua. But, by the way, the |
It's growing on me :) |
What would you like to be added:
Currently,
Prune
is only supported for built-in, and there are use-cases where we could use Prune for custom resources.Why is this needed:
this blog does a good job of covering the interpreters and based on the image, we may want to exclude labels/annotations before Work is created
The text was updated successfully, but these errors were encountered: