Update colors to maintained version #3763

DABH · 2022-02-17T01:57:16Z

Per Marak/colors.js#340, the colors package on which karma depends has been migrated to @colors/colors. This PR performs the (very simple) migration. Thanks for your help with getting this into the next release, and let me know if you need any help with getting this fix out or other maintenance tasks.

DABH · 2022-02-22T03:19:13Z

Hey @jginsburgn ! Any chance you could help me get the pipelines running for this PR? It should be a trivial change so I’m curious why I was getting failures on the first commit. Thanks in advance for your help.

jginsburgn · 2022-02-22T06:21:40Z

Hey @jginsburgn ! Any chance you could help me get the pipelines running for this PR? It should be a trivial change so I’m curious why I was getting failures on the first commit. Thanks in advance for your help.

Done! Sorry about the delay. I was OOO.

devoto13 · 2022-02-22T09:07:38Z

@DABH Looks like you've used a newer version of NPM which have updated the package-lock.json format to the version 2 and broke CI on the older Node version where older version of NPM was used. I've fixed it and I think CI should pass now.

devoto13 · 2022-02-22T09:12:10Z

We should probably still check if any official plugins rely on the implicit dependency on the colors package and decide whether we want to do the switch now or as part of the major release.

DABH · 2022-02-28T03:30:00Z

@devoto13 Thank you so much for getting everything passing! Looks like CI is happy now.

I didn't see a dependency on the old colors package in any of the plugins linked to from the README, but idk if there is another place I should look to analyze the plugins. Personally since this update is to migrate off of a compromised package, it feels like something that should not be postponed to a major release. Please just let me know how I can help and if there's anything else I can do to get this PR approved/merged. Thank you and @jginsburgn for your generous help!

devoto13

I've also checked other plugin sources and it looks like this should be safe to land.

jginsburgn · 2022-02-28T19:14:46Z

@DABH and @devoto13 thanks!

## [6.3.17](v6.3.16...v6.3.17) (2022-02-28) ### Bug Fixes * **deps:** update colors to maintained version ([#3763](#3763)) ([fca1884](fca1884))

karmarunnerbot · 2022-02-28T20:59:12Z

🎉 This PR is included in version 6.3.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [karma](https://karma-runner.github.io/) ([source](https://github.com/karma-runner/karma)) | devDependencies | patch | [`6.3.16` -> `6.3.17`](https://renovatebot.com/diffs/npm/karma/6.3.16/6.3.17) | --- ### Release Notes <details> <summary>karma-runner/karma</summary> ### [`v6.3.17`](https://github.com/karma-runner/karma/blob/HEAD/CHANGELOG.md#6317-httpsgithubcomkarma-runnerkarmacomparev6316v6317-2022-02-28) [Compare Source](karma-runner/karma@v6.3.16...v6.3.17) ##### Bug Fixes - **deps:** update colors to maintained version ([#3763](karma-runner/karma#3763)) ([fca1884](karma-runner/karma@fca1884)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1193 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [karma](https://karma-runner.github.io/) ([source](https://github.com/karma-runner/karma)) | devDependencies | minor | [`6.3.20` -> `6.4.0`](https://renovatebot.com/diffs/npm/karma/6.3.20/6.4.0) | --- ### Release Notes <details> <summary>karma-runner/karma</summary> ### [`v6.4.0`](https://github.com/karma-runner/karma/blob/HEAD/CHANGELOG.md#640-httpsgithubcomkarma-runnerkarmacomparev6320v640-2022-06-14) [Compare Source](karma-runner/karma@v6.3.20...v6.4.0) ##### Features - support SRI verification of link tags ([dc51a2e](karma-runner/karma@dc51a2e)) - support SRI verification of script tags ([6a54b1c](karma-runner/karma@6a54b1c)) #### [6.3.20](karma-runner/karma@v6.3.19...v6.3.20) (2022-05-13) ##### Bug Fixes - prefer IPv4 addresses when resolving domains ([e17698f](karma-runner/karma@e17698f)), closes [#3730](karma-runner/karma#3730) #### [6.3.19](karma-runner/karma@v6.3.18...v6.3.19) (2022-04-19) ##### Bug Fixes - **client:** error out when opening a new tab fails ([099b85e](karma-runner/karma@099b85e)) #### [6.3.18](karma-runner/karma@v6.3.17...v6.3.18) (2022-04-13) ##### Bug Fixes - **deps:** upgrade socket.io to v4.4.1 ([52a30bb](karma-runner/karma@52a30bb)) #### [6.3.17](karma-runner/karma@v6.3.16...v6.3.17) (2022-02-28) ##### Bug Fixes - **deps:** update colors to maintained version ([#3763](karma-runner/karma#3763)) ([fca1884](karma-runner/karma@fca1884)) #### [6.3.16](karma-runner/karma@v6.3.15...v6.3.16) (2022-02-10) ##### Bug Fixes - **security:** mitigate the "Open Redirect Vulnerability" ([ff7edbb](karma-runner/karma@ff7edbb)) #### [6.3.15](karma-runner/karma@v6.3.14...v6.3.15) (2022-02-05) ##### Bug Fixes - **helper:** make mkdirIfNotExists helper resilient to concurrent calls ([d9dade2](karma-runner/karma@d9dade2)), closes [/github.com/karma-runner/karma-coverage/issues/434#issuecomment-1017939333](https://github.com//github.com/karma-runner/karma-coverage/issues/434/issues/issuecomment-1017939333) #### [6.3.14](karma-runner/karma@v6.3.13...v6.3.14) (2022-02-05) ##### Bug Fixes - remove string template from client code ([91d5acd](karma-runner/karma@91d5acd)) - warn when `singleRun` and `autoWatch` are `false` ([69cfc76](karma-runner/karma@69cfc76)) - **security:** remove XSS vulnerability in `returnUrl` query param ([839578c](karma-runner/karma@839578c)) #### [6.3.13](karma-runner/karma@v6.3.12...v6.3.13) (2022-01-31) ##### Bug Fixes - **deps:** bump log4js to resolve security issue ([5bf2df3](karma-runner/karma@5bf2df3)), closes [#3751](karma-runner/karma#3751) #### [6.3.12](karma-runner/karma@v6.3.11...v6.3.12) (2022-01-24) ##### Bug Fixes - remove depreciation warning from log4js ([41bed33](karma-runner/karma@41bed33)) #### [6.3.11](karma-runner/karma@v6.3.10...v6.3.11) (2022-01-13) ##### Bug Fixes - **deps:** pin colors package to 1.4.0 due to security vulnerability ([a5219c5](karma-runner/karma@a5219c5)) #### [6.3.10](karma-runner/karma@v6.3.9...v6.3.10) (2022-01-08) ##### Bug Fixes - **logger:** create parent folders if they are missing ([0d24bd9](karma-runner/karma@0d24bd9)), closes [#3734](karma-runner/karma#3734) #### [6.3.9](karma-runner/karma@v6.3.8...v6.3.9) (2021-11-16) ##### Bug Fixes - restartOnFileChange option not restarting the test run ([92ffe60](karma-runner/karma@92ffe60)), closes [#27](karma-runner/karma#27) [#3724](karma-runner/karma#3724) #### [6.3.8](karma-runner/karma@v6.3.7...v6.3.8) (2021-11-07) ##### Bug Fixes - **reporter:** warning if stack trace contains generated code invocation ([4f23b14](karma-runner/karma@4f23b14)) #### [6.3.7](karma-runner/karma@v6.3.6...v6.3.7) (2021-11-01) ##### Bug Fixes - **middleware:** replace %X_UA_COMPATIBLE% marker anywhere in the file ([f1aeaec](karma-runner/karma@f1aeaec)), closes [#3711](karma-runner/karma#3711) #### [6.3.6](karma-runner/karma@v6.3.5...v6.3.6) (2021-10-25) ##### Bug Fixes - bump vulnerable ua-parser-js version ([6f2b2ec](karma-runner/karma@6f2b2ec)), closes [#3713](karma-runner/karma#3713) #### [6.3.5](karma-runner/karma@v6.3.4...v6.3.5) (2021-10-20) ##### Bug Fixes - **client:** prevent socket.io from hanging due to mocked clocks ([#3695](karma-runner/karma#3695)) ([105da90](karma-runner/karma@105da90)) #### [6.3.4](karma-runner/karma@v6.3.3...v6.3.4) (2021-06-14) ##### Bug Fixes - bump production dependencies within SemVer ranges ([#3682](karma-runner/karma#3682)) ([36467a8](karma-runner/karma@36467a8)), closes [#3680](karma-runner/karma#3680) #### [6.3.3](karma-runner/karma@v6.3.2...v6.3.3) (2021-06-01) ##### Bug Fixes - **server:** clean up vestigial code from proxy ([#3640](karma-runner/karma#3640)) ([f4aeac3](karma-runner/karma@f4aeac3)), closes [/tools.ietf.org/html/std66#section-3](https://github.com//tools.ietf.org/html/std66/issues/section-3) #### [6.3.2](karma-runner/karma@v6.3.1...v6.3.2) (2021-03-29) ##### Bug Fixes - fix running tests in IE9 ([#3668](karma-runner/karma#3668)) ([0055bc5](karma-runner/karma@0055bc5)), closes [/github.com/karma-runner/karma/blob/026fff870913fb6cd2858dd962935dc74c92b725/client/main.js#L14](https://github.com//github.com/karma-runner/karma/blob/026fff870913fb6cd2858dd962935dc74c92b725/client/main.js/issues/L14) [#3665](karma-runner/karma#3665) #### [6.3.1](karma-runner/karma@v6.3.0...v6.3.1) (2021-03-24) ##### Bug Fixes - **client:** clearContext after complete sent ([#3657](karma-runner/karma#3657)) ([c0962e3](karma-runner/karma@c0962e3)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1412 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

Co-authored-by: David Hyde <dabh@alumni.stanford.edu>

## [6.3.17](karma-runner/karma@v6.3.16...v6.3.17) (2022-02-28) ### Bug Fixes * **deps:** update colors to maintained version ([karma-runner#3763](karma-runner#3763)) ([fca1884](karma-runner@fca1884))

DABH mentioned this pull request Feb 17, 2022

fix: replace colors with ansi-colors #3743

Closed

DABH force-pushed the update-colors branch from fdff3e6 to ba76f3c Compare February 17, 2022 02:00

fix(deps): update colors to maintained version

96fea2a

devoto13 force-pushed the update-colors branch from 5dd9305 to 96fea2a Compare February 22, 2022 09:06

devoto13 approved these changes Feb 28, 2022

View reviewed changes

devoto13 requested a review from jginsburgn February 28, 2022 08:33

jginsburgn approved these changes Feb 28, 2022

View reviewed changes

jginsburgn merged commit fca1884 into karma-runner:master Feb 28, 2022

karmarunnerbot pushed a commit that referenced this pull request Feb 28, 2022

chore(release): 6.3.17 [skip ci]

f068854

## [6.3.17](v6.3.16...v6.3.17) (2022-02-28) ### Bug Fixes * **deps:** update colors to maintained version ([#3763](#3763)) ([fca1884](fca1884))

karmarunnerbot added the released label Feb 28, 2022

sync-by-unito bot mentioned this pull request Mar 1, 2022

build(deps-dev): bump karma from 6.3.4 to 6.3.17 numbersprotocol/capture-lite#1326

Closed

reduckted mentioned this pull request Mar 4, 2022

pin colors lib to 1.4.0 as it been hacked and version 1.4.1 is broken #3738

Closed

sync-by-unito bot mentioned this pull request May 1, 2022

build(deps-dev): bump karma from 6.3.4 to 6.3.19 numbersprotocol/capture-lite#1568

Closed

sync-by-unito bot mentioned this pull request Jun 1, 2022

build(deps-dev): bump karma from 6.3.4 to 6.3.20 numbersprotocol/capture-lite#1672

Closed

sync-by-unito bot mentioned this pull request Jul 1, 2022

build(deps-dev): bump karma from 6.3.4 to 6.4.0 numbersprotocol/capture-lite#1767

Closed

karronoli mentioned this pull request Aug 16, 2022

Bump karma from ~1.2.0 to ~6.4 in /redpen-server karronoli/redpen#10

Merged

sync-by-unito bot mentioned this pull request Sep 20, 2022

build(deps-dev): bump karma from 6.3.4 to 6.4.1 numbersprotocol/capture-lite#2098

Open

anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023

fix(deps): update colors to maintained version (karma-runner#3763)

c04c44c

Co-authored-by: David Hyde <dabh@alumni.stanford.edu>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update colors to maintained version #3763

Update colors to maintained version #3763

DABH commented Feb 17, 2022

DABH commented Feb 22, 2022

jginsburgn commented Feb 22, 2022

devoto13 commented Feb 22, 2022

devoto13 commented Feb 22, 2022

DABH commented Feb 28, 2022

devoto13 left a comment

jginsburgn commented Feb 28, 2022

karmarunnerbot commented Feb 28, 2022

Update colors to maintained version #3763

Update colors to maintained version #3763

Conversation

DABH commented Feb 17, 2022

DABH commented Feb 22, 2022

jginsburgn commented Feb 22, 2022

devoto13 commented Feb 22, 2022

devoto13 commented Feb 22, 2022

DABH commented Feb 28, 2022

devoto13 left a comment

Choose a reason for hiding this comment

jginsburgn commented Feb 28, 2022

karmarunnerbot commented Feb 28, 2022