Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid new branches #3760

Closed
jginsburgn opened this issue Feb 10, 2022 · 2 comments
Closed

Forbid new branches #3760

jginsburgn opened this issue Feb 10, 2022 · 2 comments

Comments

@jginsburgn
Copy link
Member

@devoto13 I propose that we should forbid creating new branches on this repository and work by having PRs have head branches from repo forks. This will ensure that this repo is always tidy (i.e. no stale branches). WDYT?

@devoto13
Copy link
Collaborator

devoto13 commented Feb 10, 2022

One reason why we may want to use branches in this repo is to run CI with BrowserStack and SauceLabs enabled as branches in this repo will have access to the tokens while branches in forks won't have it unless we copy the same values to our own forks. I agree about keeping this repository tidy as much as possible, but I'm not sure if outright prohibiting to create braches is a good idea as we'll loose a possibility to debug CI failures which comes quite handy sometimes. E.g. I could not reproduce #3730 (comment) on my local machine, but it reproduced on CI. I think those branches from John were also related to debugging CI issues.

@jginsburgn
Copy link
Member Author

You're right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants