Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updates to the documentation to support new markdown renderer #3672

Merged
merged 5 commits into from Apr 12, 2021

Conversation

devoto13
Copy link
Collaborator

PR to switch to the new markdown renderer for the documentation website: karma-runner/karma-runner.github.com#62.

Had to put metadata between --- --- (Jekyll syntax) as the previous syntax was not supported by the new Markdown parser. Also several small changes to the markdown syntax for the new Markdown parser (see commits for details).

It is not recognized as a heading by the markdown parser without a whitespace.
Old parser considered this the same list, but new parser assumes that these are two separate lists. Technically it should be a nested list, but it is old and shouldn't really matter. I'm doing this change to reduce the diff I need to review after switching to the new markdown parser.
Items nested in the list item, must be indented 3 spaces, not 2 spaces. New parser produced a pretty messed up markup from the invalid markdown.
@karmarunnerbot
Copy link
Member

Build karma 576 completed (commit b71bd1951f by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 575 completed (commit b71bd1951f by @devoto13)

@johnjbarton johnjbarton merged commit 94cf15e into karma-runner:master Apr 12, 2021
@devoto13 devoto13 deleted the docs branch May 4, 2021 14:33
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 6.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
…arma-runner#3672)


Companion PR for karma-runner/karma-runner.github.com#62.

* docs: fix invalid heading syntax

It is not recognized as a heading by the markdown parser without a whitespace.

* docs: fix weird syntax to reduce diff

Old parser considered this the same list, but new parser assumes that these are two separate lists. Technically it should be a nested list, but it is old and shouldn't really matter. I'm doing this change to reduce the diff I need to review after switching to the new markdown parser.

* docs: fix invalid markdown

Items nested in the list item, must be indented 3 spaces, not 2 spaces. New parser produced a pretty messed up markup from the invalid markdown.

* docs: remove redundant whitespaces in the list items
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants