fix(server): clean up vestigial code from proxy

[jginsburgn]

When using the proxy feature of Karma, the target value can include the scheme. It was used to determine the https variable to be sent to the http-proxy .createProxyServer method. However, it is now disregarded by that package. Therefore, this PR cleans it up.

[karmarunnerbot]

✅ Build karma 507 completed (commit 3701f5f956 by @jginsburgn)

[AppVeyorBot]

✅ Build karma 2904 completed (commit 3701f5f956 by @jginsburgn)

[karmarunnerbot]

✅ Build karma 506 completed (commit 3701f5f956 by @jginsburgn)

[karmarunnerbot]

✅ Build karma 508 completed (commit 796b6a4738 by @jginsburgn)

[AppVeyorBot]

✅ Build karma 2905 completed (commit 796b6a4738 by @jginsburgn)

[karmarunnerbot]

✅ Build karma 507 completed (commit 796b6a4738 by @jginsburgn)

[devoto13]

The fix looks correct to me. An example would be a path-only proxy when Karma is configured to run over https. E.g.

{
  protocol: 'https',
  proxies: {
    '/img/': '/base/test/images/'
  }
  ...
}

> url.parse('/base/test/images/')
Url {
  protocol: null,
  slashes: null,
  auth: null,
  host: null,
  port: null,
  hostname: null,
  hash: null,
  search: null,
  query: null,
  pathname: '/base/test/images/',
  path: '/base/test/images/',
  href: '/base/test/images/'
}

See Loading assets section (near the end): http://karma-runner.github.io/6.0/config/files.html

Can you add a test case based on the above example, please?

[johnjbarton]

Yes the test would clarify the use case

[karmarunnerbot]

✅ Build karma 584 completed (commit 8f56bf971a by @jginsburgn)

[AppVeyorBot]

✅ Build karma 2981 completed (commit 8f56bf971a by @jginsburgn)

[karmarunnerbot]

✅ Build karma 583 completed (commit 8f56bf971a by @jginsburgn)

[jginsburgn]

Upon trying to add a test for the use case that @devoto13 mentioned, I figured that it makes no sense to have a comms protocol (e.g. https or http) when proxying requests between paths. That is because the target path is in the local filesystem and no connection should be done.

[AppVeyorBot]

✅ Build karma 2982 completed (commit e17e5fbd22 by @jginsburgn)

[karmarunnerbot]

✅ Build karma 585 completed (commit e17e5fbd22 by @jginsburgn)

[karmarunnerbot]

✅ Build karma 584 completed (commit e17e5fbd22 by @jginsburgn)

[AppVeyorBot]

✅ Build karma 2983 completed (commit b16a33b503 by @jginsburgn)

[jginsburgn]

Investigating more, the NPM module http-proxy that we are using, does not make use of the https variable that we were sending it. Also, it disregards the agent configuration. Therefore, I cleaned this logic up and its corresponding tests.

[karmarunnerbot]

✅ Build karma 586 completed (commit b16a33b503 by @jginsburgn)

[karmarunnerbot]

✅ Build karma 585 completed (commit b16a33b503 by @jginsburgn)

[jginsburgn]

Only the native raw agents are used, according to my understanding.
https://github.com/http-party/node-http-proxy/blob/9b96cd725127a024dabebec6c7ea8c807272223d/lib/http-proxy/passes/web-incoming.js#L11

[devoto13]

The naming is confusing.

I haven't really debugged it, but from a quick code scan the agent option is copied into requestOptions here and passed through here and here to here and eventually into agent option of the request() method from either http or https module, which you referenced in you comment.

[jginsburgn]

@devoto13 you're right! I missed that path :/. Let me fix this PR.

[AppVeyorBot]

✅ Build karma 2984 completed (commit 87a026fe86 by @jginsburgn)

[karmarunnerbot]

✅ Build karma 587 completed (commit 87a026fe86 by @jginsburgn)

[karmarunnerbot]

✅ Build karma 586 completed (commit 87a026fe86 by @jginsburgn)

[devoto13]

LGTM

[AppVeyorBot]

✅ Build karma 2985 completed (commit 7fa2499251 by @jginsburgn)

[karmarunnerbot]

✅ Build karma 588 completed (commit 7fa2499251 by @jginsburgn)

[karmarunnerbot]

✅ Build karma 587 completed (commit 7fa2499251 by @jginsburgn)

[AppVeyorBot]

✅ Build karma 2986 completed (commit 87beaa51db by @jginsburgn)

[karmarunnerbot]

✅ Build karma 589 completed (commit 87beaa51db by @jginsburgn)

[karmarunnerbot]

✅ Build karma 588 completed (commit 87beaa51db by @jginsburgn)

[karmarunnerbot]

🎉 This PR is included in version 6.3.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀