Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use colors/safe #3548

Merged
merged 1 commit into from Sep 2, 2020
Merged

Conversation

kriskowal
Copy link
Contributor

This change switches use of the color module for color/safe to avoid mutating the shared primordials. Tools like SES make the primordials immutable to mitigate some kinds of supply-chain attacks.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@karmarunnerbot
Copy link
Member

Build karma 346 completed (commit a435e316c2 by @kriskowal)

@AppVeyorBot
Copy link

Build karma 2744 completed (commit a435e316c2 by @kriskowal)

@karmarunnerbot
Copy link
Member

Build karma 345 completed (commit a435e316c2 by @kriskowal)

Copy link
Collaborator

@devoto13 devoto13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Please accept the CLA as request by bot here, so we can merge your PR.

@kriskowal
Copy link
Contributor Author

@googlebot I signed it!

At least, I believe @dtribble has signed it on behalf of @Agoric and it’s worth giving the bot a poke to check.

@kriskowal
Copy link
Contributor Author

@googlebot I signed it!

1 similar comment
@kriskowal
Copy link
Contributor Author

@googlebot I signed it!

@devoto13
Copy link
Collaborator

devoto13 commented Sep 2, 2020

Not sure what is wrong with googlebot. It should have responded to you like in #3531. Maybe @johnjbarton can help investigate it?

@johnjbarton
Copy link
Contributor

Hi @kriskowal The commit comes from kris@cixar.com not from agoric.com so maybe that is related?

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@kriskowal
Copy link
Contributor Author

I see. I had reset the author, but didn’t follow through on the force push. Looks like it stuck this time.

@AppVeyorBot
Copy link

Build karma 2756 completed (commit 0d3f273430 by @kriskowal)

@karmarunnerbot
Copy link
Member

Build karma 358 completed (commit 0d3f273430 by @kriskowal)

@karmarunnerbot
Copy link
Member

Build karma 357 completed (commit 0d3f273430 by @kriskowal)

@johnjbarton johnjbarton merged commit ac7b73a into karma-runner:master Sep 2, 2020
@kriskowal
Copy link
Contributor Author

Thanks @johnjbarton. Always good to cross paths.

@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 5.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants