-
Notifications
You must be signed in to change notification settings - Fork 1.7k
refactor: use colors/safe #3548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
✅ Build karma 346 completed (commit a435e316c2 by @kriskowal) |
✅ Build karma 2744 completed (commit a435e316c2 by @kriskowal) |
✅ Build karma 345 completed (commit a435e316c2 by @kriskowal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
Please accept the CLA as request by bot here, so we can merge your PR.
@googlebot I signed it! At least, I believe @dtribble has signed it on behalf of @Agoric and it’s worth giving the bot a poke to check. |
@googlebot I signed it! |
1 similar comment
@googlebot I signed it! |
Not sure what is wrong with googlebot. It should have responded to you like in #3531. Maybe @johnjbarton can help investigate it? |
Hi @kriskowal The commit comes from kris@cixar.com not from agoric.com so maybe that is related? |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
I see. I had reset the author, but didn’t follow through on the force push. Looks like it stuck this time. |
✅ Build karma 2756 completed (commit 0d3f273430 by @kriskowal) |
✅ Build karma 358 completed (commit 0d3f273430 by @kriskowal) |
✅ Build karma 357 completed (commit 0d3f273430 by @kriskowal) |
Thanks @johnjbarton. Always good to cross paths. |
🎉 This PR is included in version 5.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This change switches use of the
color
module forcolor/safe
to avoid mutating the shared primordials. Tools like SES make the primordials immutable to mitigate some kinds of supply-chain attacks.