Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: if preprocessor is async function and doesn't return a content t… #3387

Merged
merged 1 commit into from Oct 18, 2019

Conversation

anthony-redFox
Copy link
Contributor

…hen await donePromise

@anthony-redFox
Copy link
Contributor Author

@johnjbarton please take a look

@AppVeyorBot
Copy link

Build karma 2431 completed (commit 3f9ca408af by @anthony-redFox)

@karmarunnerbot
Copy link
Member

Build karma 33 completed (commit 3f9ca408af by @anthony-redFox)

@karmarunnerbot
Copy link
Member

Build karma 32 completed (commit 3f9ca408af by @anthony-redFox)

Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for the normal async path where done() is not called.

lib/preprocessor.js Show resolved Hide resolved
test/unit/preprocessor.spec.js Outdated Show resolved Hide resolved
@anthony-redFox
Copy link
Contributor Author

@johnjbarton Thanks for review. Add new unit tests and comments

@AppVeyorBot
Copy link

Build karma 2432 completed (commit 23033eaa42 by @anthony-redFox)

@karmarunnerbot
Copy link
Member

Build karma 33 completed (commit 23033eaa42 by @anthony-redFox)

@karmarunnerbot
Copy link
Member

Build karma 34 completed (commit 23033eaa42 by @anthony-redFox)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants