Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Preprocessor can return Promise #3376

Merged
merged 1 commit into from Oct 11, 2019
Merged

feat: Preprocessor can return Promise #3376

merged 1 commit into from Oct 11, 2019

Conversation

anthony-redFox
Copy link
Contributor

Similar that mocha support like you can execute done or return Promise

@anthony-redFox
feat: Preprocessor can return Promise
4cee35c 
similar that mocha support like you can execute done or return Promise
@karmarunnerbot
Copy link
Member

✅ Build karma 9 completed (commit 2c80f8e24c by @anthony-redFox)

@AppVeyorBot
Copy link

✅ Build karma 2407 completed (commit 2c80f8e24c by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 8 completed (commit 2c80f8e24c by @anthony-redFox)

johnjbarton
johnjbarton suggested changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first commit is ready but I'd like to look at the second commit separately

lib/preprocessor.js Outdated Show resolved Hide resolved
@AppVeyorBot
Copy link

✅ Build karma 2409 completed (commit 47c2de6151 by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 11 completed (commit 47c2de6151 by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 10 completed (commit 47c2de6151 by @anthony-redFox)

@johnjbarton johnjbarton merged commit 3ffcd83 into karma-runner:master Oct 11, 2019
@seebees seebees mentioned this pull request Oct 18, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 12, 2020
Closed
@karronoli karronoli mentioned this pull request Aug 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnjbarton johnjbarton johnjbarton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anthony-redFox @karmarunnerbot @AppVeyorBot @johnjbarton