Karma returns non-zero exit code with disabled failOnFailingTestSuite when all tests are failed

[ilgonmic]

Expected behaviour

exit code - 0

Actual behaviour

exit code - 1

Environment Details

• Karma version (output of karma --version):
  Karma version: 4.0.1

• Relevant part of your karma.config.js file
  "failOnFailingTestSuite": false

Steps to reproduce the behaviour

1. "failOnFailingTestSuite": false
2. All tests are failed
3. karma start

Details

Is it consistent behaviour, if I set failOnFailingTestSuite (from #3116) on false, but Karma returns non-zero exit code, when all my tests are failed?

Seems that these lines are root cause, is it actual since we have failOnFailingTestSuite property?

karma/lib/browser.js

Lines 90 to 92 in 6235e68

	if (!this.lastResult.success) {
	this.lastResult.error = true
	}