fix(reporter): format stack with 1-based column #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Columns in original stack are 1-based, but SourceMapConsumer.prototype.originalPositionFor(generatedPosition) accepts 0-based column and returns 0-based column too. This change converts columns from 1-based to 0-based forth and back. Closes #3324
|
The Travis CI build was failed for "Node.js 8" configuration in the same way as it fails for karma master (https://travis-ci.org/karma-runner/karma). So, seems this failed check can be skipped. |
|
@johnjbarton Could you please take a look at this PR? It helps IDE to annotate correctly method call where assertion is failed. |
johnjbarton
approved these changes
Jun 17, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Columns in original stack are 1-based, but
SourceMapConsumer.prototype.originalPositionFor(generatedPosition)
accepts 0-based column and returns 0-based column too.
This change converts columns from 1-based to 0-based forth and back.
Closes #3324