Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): Add error handler for webserver socket. #3300

Merged
merged 1 commit into from Apr 23, 2019
Merged

fix(server): Add error handler for webserver socket. #3300

merged 1 commit into from Apr 23, 2019

Conversation

johnjbarton
Copy link
Contributor

…ockets open

@johnjbarton johnjbarton requested a review from kyliau April 19, 2019 16:23
@johnjbarton
fix(server): Add error handler for webserver socket.
5774488 
Some times connection arrive, are given 404 responses, then disconnect,
resulting in ECONNRESET errors on the socket.  After we began monitoring
UncaughtExceptions, these errors show up. Suppress them with a handler
that ignores errors.
@johnjbarton johnjbarton changed the title fix(server): Don't emit infrastructure_failure on ECONNRESET and no s… fix(server): Add error handler for webserver socket. Apr 23, 2019
@johnjbarton
Copy link
Contributor Author

PTAL complete rewrite

@johnjbarton johnjbarton merged commit fe9a1dd into karma-runner:master Apr 23, 2019
@johnjbarton johnjbarton deleted the not-karma-error branch December 23, 2020 20:13
@karronoli karronoli mentioned this pull request Aug 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyliau kyliau kyliau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnjbarton @kyliau