Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): remove phantomjs in favor of chrome headless #3175

Merged
merged 2 commits into from Oct 14, 2018
Merged

fix(config): remove phantomjs in favor of chrome headless #3175

merged 2 commits into from Oct 14, 2018

Conversation

lusarz
Copy link
Contributor

@lusarz lusarz commented Oct 12, 2018

fix #3088

@johnjbarton
Copy link
Contributor

The crash during travis maybe related to karma-runner/karma-chrome-launcher#188

@lusarz
Copy link
Contributor Author

lusarz commented Oct 13, 2018

I fixed issue by creating custom launcher with --no-sandbox flag passed to chrome.

@johnjbarton johnjbarton merged commit 0f8b2b1 into karma-runner:master Oct 14, 2018
edmorley
edmorley reviewed Oct 23, 2018
View reviewed changes
package.json
@@ -378,6 +378,7 @@
"mime": "^2.3.1",
"minimatch": "^3.0.2",
"optimist": "^0.6.1",
"puppeteer": "^1.9.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnjbarton, hi :-) Was this meant to be added under devDependencies instead?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edmorley This is already fixed on master. See #3191.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry missed that - thank you :-)

@dependencies dependencies bot mentioned this pull request Oct 23, 2018
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 12, 2019
Merged
@karronoli karronoli mentioned this pull request Aug 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmorley edmorley edmorley left review comments

@devoto13 devoto13 devoto13 left review comments

@johnjbarton johnjbarton johnjbarton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Perform karma CI feature tests on headless chromium rather than phantomjs
4 participants
@lusarz @johnjbarton @edmorley @devoto13