Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frameworks): report start() errors back to server. #3126

Merged
merged 1 commit into from Sep 5, 2018
Merged

feat(frameworks): report start() errors back to server. #3126

merged 1 commit into from Sep 5, 2018

Conversation

johnjbarton
Copy link
Contributor

No description provided.

@johnjbarton johnjbarton requested a review from zzo September 4, 2018 23:46
zzo
zzo approved these changes Sep 4, 2018
View reviewed changes
Copy link
Contributor

@zzo zzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened before if this.start() threw an Exception - it just sat there broken?

@johnjbarton
Copy link
Contributor Author

Yes. The error is reported in the browser devtools if you have them open. But otherwise only a timeout on the process will stop it.

@johnjbarton johnjbarton merged commit 8257375 into karma-runner:master Sep 5, 2018
@dependencies dependencies bot mentioned this pull request Oct 23, 2018
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 12, 2019
Merged
@johnjbarton johnjbarton deleted the catchstart branch December 23, 2020 20:13
@karronoli karronoli mentioned this pull request Aug 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzo zzo zzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnjbarton @zzo