Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when mixing browser launched on SauceLabs and others #232

Closed
mjeanroy opened this issue Nov 29, 2020 · 1 comment · Fixed by #233
Closed

Error when mixing browser launched on SauceLabs and others #232

mjeanroy opened this issue Nov 29, 2020 · 1 comment · Fixed by #233
Labels
released

Comments

@mjeanroy
Copy link
Contributor

Hi,

When I try to run my test suite with browsers launched through saucelabs launcher and another one (say ChromeHeadless available locally), the test suite fails with the following stacktrace:

[19:23:33] TypeError: Cannot read property 'results' of undefined
    at SaucelabsReporter.onSpecComplete (/home/runner/work/jasmine-dom-spec/jasmine-dom-spec/node_modules/karma-sauce-launcher/dist/reporter/reporter.js:29:35)
    at Server.<anonymous> (/home/runner/work/jasmine-dom-spec/jasmine-dom-spec/node_modules/karma/lib/events.js:40:26)
    at Server.emit (events.js:327:22)
    at Server.EventEmitter.emit (domain.js:548:15)
    at Browser.onResult (/home/runner/work/jasmine-dom-spec/jasmine-dom-spec/node_modules/karma/lib/browser.js:159:20)
    at Socket.<anonymous> (/home/runner/work/jasmine-dom-spec/jasmine-dom-spec/node_modules/karma/lib/browser.js:209:42)
    at Socket.emit (events.js:315:20)
    at Socket.EventEmitter.emit (domain.js:486:12)
    at /home/runner/work/jasmine-dom-spec/jasmine-dom-spec/node_modules/socket.io/lib/socket.js:528:12
    at processTicksAndRejections (internal/process/task_queues.js:75:11)

You can see it here.

I'm using karma-sauce-launcher@4.3.3 and karma@5.2.3
mjeanroy added a commit to mjeanroy/karma-sauce-launcher that referenced this issue Nov 29, 2020
@mjeanroy
fix: fix reporter with browsers not launched through launcher
39943d7 
Close karma-runner#232
@mjeanroy mjeanroy mentioned this issue Nov 29, 2020
Merged
karmarunnerbot pushed a commit that referenced this issue Nov 30, 2020
@semantic-release-bot
chore(release): 4.3.4 [skip ci]
b119018 
## [4.3.4](v4.3.3...v4.3.4) (2020-11-30)

### Bug Fixes

* fix reporter with browsers not launched through launcher ([39943d7](39943d7)), closes [#232](#232)
@karmarunnerbot
Copy link
Member

🎉 This issue has been resolved in version 4.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix reporter with browsers not launched through launcher mjeanroy/karma-sauce-launcher
2 participants
@mjeanroy @karmarunnerbot