From f4a573e1d93a1def894fa65bf9a6a60c215e0b26 Mon Sep 17 00:00:00 2001 From: yinm Date: Sat, 28 Apr 2018 21:07:42 +0900 Subject: [PATCH 1/2] fix: return false for every entry is irrelevant --- test/adapter.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/adapter.spec.js b/test/adapter.spec.js index d932c38..f408d2f 100644 --- a/test/adapter.spec.js +++ b/test/adapter.spec.js @@ -465,7 +465,7 @@ describe('jasmine adapter', function () { }) it('should return the all stack entries if every entry is irrelevant', function () { - spyOn(window, 'isExternalStackEntry').and.returnValue(true) + spyOn(window, 'isExternalStackEntry').and.returnValue(false) expect(getRelevantStackFrom('a\nb\nc')).toEqual(['a', 'b', 'c']) }) From c25a0b8e8e221368a8a21957e04f6b27aa70b27f Mon Sep 17 00:00:00 2001 From: yinm Date: Sat, 5 May 2018 08:29:12 +0900 Subject: [PATCH 2/2] Add a comment ref: https://github.com/karma-runner/karma-jasmine/pull/206#discussion_r186142116 --- test/adapter.spec.js | 1 + 1 file changed, 1 insertion(+) diff --git a/test/adapter.spec.js b/test/adapter.spec.js index f408d2f..6db52dc 100644 --- a/test/adapter.spec.js +++ b/test/adapter.spec.js @@ -465,6 +465,7 @@ describe('jasmine adapter', function () { }) it('should return the all stack entries if every entry is irrelevant', function () { + // Check the case where the filteredStack is empty spyOn(window, 'isExternalStackEntry').and.returnValue(false) expect(getRelevantStackFrom('a\nb\nc')).toEqual(['a', 'b', 'c']) })