Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filter): match any portion of a spec name #270

Merged
merged 1 commit into from May 28, 2020

Conversation

johnjbarton
Copy link
Contributor

jasmine tests are named suite-name + spec-name. The links printed by
karma-jasmine-html-reporter include links for suite-name (only). To support
running the suite, allow the filter to match any part of the test name.

Fixes #256

jasmine tests are named suite-name + spec-name. The links printed by
karma-jasmine-html-reporter include links for suite-name (only). To support
running the suite, allow the filter to match any part of the test name.
@johnjbarton johnjbarton requested a review from kyliau May 28, 2020 19:08
@johnjbarton johnjbarton merged commit ded4c4b into karma-runner:master May 28, 2020
karmarunnerbot pushed a commit that referenced this pull request May 28, 2020
## [3.3.1](v3.3.0...v3.3.1) (2020-05-28)

### Bug Fixes

* **filter:** match any portion of a spec name ([#270](#270)) ([ded4c4b](ded4c4b)), closes [#256](#256)
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 3.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

parloti added a commit to parloti/karma-jasmine that referenced this pull request May 31, 2020
jasmine tests are named suite-name + spec-name. The links printed by
karma-jasmine-html-reporter include links for suite-name (only). To support
running the suite, allow the filter to match ONLY the START portion of the test name.
Fixes karma-runner#256 karma-runner#270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in 3.1.0 break custom karma-jasmine-html-reporter spec filtering
3 participants