Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor README.md tweaks #258

Merged
merged 1 commit into from Jan 13, 2020
Merged

chore: minor README.md tweaks #258

merged 1 commit into from Jan 13, 2020

Conversation

XhmikosR
Copy link
Collaborator

No description provided.

Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the PR description be
chore(readme): minor tweaks
?

@XhmikosR
Copy link
Collaborator Author

I'm not familiar with conventional commit messages, so just let me know what to use

@johnjbarton
Copy link
Contributor

the new husky/commitlint should be running so if they pass it should be ok. I just usually prefer the domain-scoped titles. kind(scope): what-changed.

@johnjbarton johnjbarton merged commit a813c8a into master Jan 13, 2020
@XhmikosR
Copy link
Collaborator Author

@johnjbarton one last thing: can you enable the delete HEAD branches in all karma repositories? Now the merged branches are left behind.

@XhmikosR XhmikosR deleted the XhmikosR-patch-1 branch January 13, 2020 17:42
@johnjbarton
Copy link
Contributor

johnjbarton commented Jan 13, 2020 via email

@XhmikosR
Copy link
Collaborator Author

Yeah, I don't use it either. Only squash and rebase, but it doesn't matter if you are consistent :)

@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants