Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(adapter): handle new Jasmine optional behavior for specs without expectations #238

Conversation

dtychshenko
Copy link
Contributor

In the next version of Jasmine, a new configuration option failSpecWithNoExpectations will be added. If turned ON, Jasmine will be reporting specs that have not run any expectations as failed Subsequently, this change is to update the adapter for such scenario.

See the corresponding feature request in Jasmine. Please don't mind the Closed status of the Issue/PR, and see from the pull request comments and history that the feature has already been implemented/merged into Jasmine. The status is Closed because the owner merged and closed it manually.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@dtychshenko
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the PR would be clearer if described more specifically:
feat(adapter): log when Jasmine fails because no expect() were run.

Thanks!

test/adapter.spec.js Outdated Show resolved Hide resolved
@dtychshenko dtychshenko force-pushed the feature-fail-spec-with-no-expectations branch from b57a7af to ddc14cf Compare September 10, 2019 02:55
@dtychshenko
Copy link
Contributor Author

Thanks for reviewing! I've updated as per suggestions.

@johnjbarton johnjbarton merged commit 646796e into karma-runner:master Sep 10, 2019
@johnjbarton
Copy link
Contributor

Thanks

@arusak
Copy link

arusak commented Oct 11, 2019

When is this feature going to be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants