Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding timeout configuration option #211

Merged
merged 2 commits into from Jun 21, 2018
Merged

Adding timeout configuration option #211

merged 2 commits into from Jun 21, 2018

Conversation

fadc80
Copy link
Contributor

@fadc80 fadc80 commented Jun 19, 2018

Adding an option to change the default jasmine timeout interval globally.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@fadc80
Copy link
Contributor Author

fadc80 commented Jun 19, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@fadc80
Copy link
Contributor Author

fadc80 commented Jun 20, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@fadc80
Copy link
Contributor Author

fadc80 commented Jun 21, 2018

My motivation for this PR was explained in your mailing list.

@johnjbarton johnjbarton merged commit 5b45cc1 into karma-runner:master Jun 21, 2018
@fadc80
Copy link
Contributor Author

fadc80 commented Jun 22, 2018

When are you planning to release a new version?

@aleshaanddustin18
Copy link

aleshaanddustin18 commented Jun 22, 2018 via email

@fadc80
Copy link
Contributor Author

fadc80 commented Jun 22, 2018

Karma-jasmine plugin

@fadc80 fadc80 mentioned this pull request Jun 24, 2018
@dmk1111
Copy link

dmk1111 commented Aug 17, 2018

@johnjbarton @dignifiedquire @zzo

Could you please respond with some estimations, when next release that will include this feature is planned?

Thank you!

@webmaster128
Copy link

Ahhh, I was trying to use this feature but it is not released yet – makes sense

@johnjbarton
Copy link
Contributor

Now that karma 3.0 is out I plan a karma-jasmine release but it will deps jasmine 3.x and I have many tests on jasmine 2.x to migrate first.

@mariotacke
Copy link

Any news on this? Would love to use the timeoutInterval. The README already has it as an option.

If you want to pass configuration options directly to jasmine you can do this in the following way

module.exports = function(config) {
  config.set({
    client: {
      jasmine: {
        random: true,
        seed: '4321',
        stopOnFailure: true,
        failFast: true,
        timeoutInterval: 1000
      }
    }
  })
}

@webmaster128
Copy link

Works like a charm in the recent 2.x release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants