Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention/list all available browser launch configs #91

Open
gekkedev opened this issue May 14, 2019 · 0 comments
Open

Mention/list all available browser launch configs #91

gekkedev opened this issue May 14, 2019 · 0 comments

Comments

@gekkedev
Copy link

gekkedev commented May 14, 2019

The file karma.conf.js is configured for the browser configs Firefox and FirefoxHeadless whilst the Readme features an example karma config using Firefox, FirefoxDeveloper, FirefoxAurora and FirefoxNightly.
Only diving into the code made me find the full list.

module.exports = {
  'launcher:Firefox': ['type', FirefoxBrowser],
  'launcher:FirefoxHeadless': ['type', FirefoxHeadlessBrowser],
  'launcher:FirefoxDeveloper': ['type', FirefoxDeveloperBrowser],
  'launcher:FirefoxDeveloperHeadless': ['type', FirefoxDeveloperHeadlessBrowser],
  'launcher:FirefoxAurora': ['type', FirefoxAuroraBrowser],
  'launcher:FirefoxAuroraHeadless': ['type', FirefoxAuroraHeadlessBrowser],
  'launcher:FirefoxNightly': ['type', FirefoxNightlyBrowser],
  'launcher:FirefoxNightlyHeadless': ['type', FirefoxNightlyHeadlessBrowser]
}

IMHO it would be very useful to list these various configurations in the readme. It's been done for the Chrome-Launcher as well. Might eventually create a PR if approveable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant