Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Automation for default Chrome Browser #197

Merged
merged 1 commit into from Apr 8, 2019
Merged

Enable Automation for default Chrome Browser #197

merged 1 commit into from Apr 8, 2019

Conversation

rgant
Copy link
Contributor

@rgant rgant commented Apr 5, 2019

Trying to get rid of the save password prompt while running tests and this seems to be the flag to do it now.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@rgant
Copy link
Contributor Author

rgant commented Apr 5, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@rogeriopvl
Copy link
Collaborator

Thanks for the PR @rgant 👍

@rogeriopvl rogeriopvl merged commit a359787 into karma-runner:master Apr 8, 2019
@rogeriopvl
Copy link
Collaborator

@johnjbarton can we do a release with this?

@rgant rgant deleted the enable-automation branch April 22, 2019 14:25
@rgant
Copy link
Contributor Author

rgant commented Apr 22, 2019

In the mean time to get this functionality I've added the following customLauncher to my karma.conf.js:

    customLaunchers: {
      AutomatedChrome: {
        base: 'Chrome',
        flags: ['--enable-automation'],
      },
      // https://github.com/angular/angular-cli/blob/master/docs/documentation/stories/continuous-integration.md
      ChromeHeadlessCI: {
        base: 'ChromeHeadless',
        flags: ['--no-sandbox'],
      },
    },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants