Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable clippy in CI for stable once clap issues addressed. #313

Closed
micolous opened this issue Apr 22, 2023 · 1 comment · Fixed by #315
Closed

Re-enable clippy in CI for stable once clap issues addressed. #313

micolous opened this issue Apr 22, 2023 · 1 comment · Fixed by #315

Comments

@micolous
Copy link
Collaborator

#312 temporarily disabled Clippy in CI for 1.69 due to spuriously-failing clap correctness checks: rust-lang/rust-clippy#10421

We'll need to revert that at some point once the upstream issue is fixed in a stable release.

There's an existing request to cherry-pick the fix in rust-lang/rust-clippy#10685

@micolous
Copy link
Collaborator Author

It looks like clap 3.2.24 just disabled the correctness lints in the macros, which I think should let users explicitly disable those checks... which means we'll have a bunch of clippy allow rules for clap.

clap 4.2.x looks like it doesn't have the same issue, so migrating to that may be the easier way to address this. I've started on this in #315.

micolous added a commit to micolous/webauthn-rs that referenced this issue Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant