Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add require kaminari/core to kaminari-activerecord #896

Merged
merged 1 commit into from Jun 27, 2017

Conversation

yhara
Copy link
Contributor

@yhara yhara commented Jun 27, 2017

I tried to use kaminari-activerecord in my Sinatra app, and noticed that two require's are actually needed:

Gemfile:

gem 'kaminari-activerecord'

app.rb:

require 'kaminari/core'  # error is raised without this
require 'kaminari/activerecord'

This PR allows you to load this gem just by:

require 'kaminari/activerecord'

So that when using sinatra-activerecord independently (say, for a Sinatra app),
you can load this gem just by `require 'sinatra/activerecord'`.
@amatsuda amatsuda merged commit fddd5ea into kaminari:master Jun 27, 2017
@amatsuda
Copy link
Member

@yhara Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants