New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the redundant argument of warn #852

Merged

amatsuda merged 1 commit into kaminari:master from tsuwatch:fix/warn

Jan 18, 2017

Contributor

tsuwatch commented Jan 18, 2017 •

edited

When I use max_pages_per in Rails4, warn raise an error.

In Rails4, callstack is caller , and it is given by default. https://github.com/rails/rails/blob/4-0-stable/activesupport/lib/active_support/deprecation/reporting.rb#L17
In Rails5, caller_locations(2) is given by default, too. https://github.com/rails/rails/blob/5-0-stable/activesupport/lib/active_support/deprecation/reporting.rb#L19


          Remove the redundant argument of warn

87d6c87

Member

amatsuda commented Jan 18, 2017

@tsuwatch Makes sense. Thanks!

amatsuda merged commit 8bc8bb2 into kaminari:master

Contributor Author

tsuwatch commented Jan 18, 2017

@amatsuda Thanks! 😆

tsuwatch deleted the fix/warn branch

January 18, 2017 11:44

This was referenced Mar 14, 2021

Bump kaminari from 0.16.1 to 1.2.1 shyaam/jobs#4

Open

Bump kaminari from 0.16.3 to 1.2.1 perangusta/helpy#3

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment