Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify required ruby version #847

Merged
merged 1 commit into from Jan 11, 2017
Merged

Conversation

timoschilling
Copy link
Contributor

Kaminari 1.0 works only with Ruby >2, this helps Bundler to find Kaminari versions for Ruby 1.9

@amatsuda
Copy link
Member

amatsuda commented Jan 11, 2017

@timoschilling Well, I think you made a good point, but since we've already released 1.0.0 that doesn't include this directive, I'm afraid adding this to the next release won't actually help the 1.9 users to find the one that works for them.

I'm wondering if we'd better have this in the gemspec still...

@timoschilling
Copy link
Contributor Author

Yes it don't solve any Problem, but it will help in some cases, for example a Gem which uses kaminari can say kaminari !=1.0.0 and it will work. ActiveAdmin has this problem.

@amatsuda
Copy link
Member

All right, I'll merge this. TBH I'm still not 100% sure how would this help the ActiveAdmin's case, but it shouldn't be a bad thing to have in our gemspec anyway.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants