fix: Handle allowed engines #1108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #1071
Currently if you're using tailwindcss with rails, it will bypass this field as
tailwindcss.Adding a small validation to ensure only allowed engines can be handled.
Fixed behaviour
# in rails project with tailwindcss $ rails g kaminari:views default create app/views/kaminari/_first_page.html.erb create app/views/kaminari/_gap.html.erb create app/views/kaminari/_last_page.html.erb create app/views/kaminari/_next_page.html.erb create app/views/kaminari/_page.html.erb create app/views/kaminari/_paginator.html.erb create app/views/kaminari/_prev_page.html.erb $ rails d kaminari:views default remove app/views/kaminari/_first_page.html.erb remove app/views/kaminari/_gap.html.erb remove app/views/kaminari/_last_page.html.erb remove app/views/kaminari/_next_page.html.erb remove app/views/kaminari/_page.html.erb remove app/views/kaminari/_paginator.html.erb remove app/views/kaminari/_prev_page.html.erb