Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indirect dependency on regex #3

Closed
davidgraeff opened this issue Sep 7, 2019 · 1 comment
Closed

Indirect dependency on regex #3

davidgraeff opened this issue Sep 7, 2019 · 1 comment

Comments

@davidgraeff
Copy link

Thanks for this crate!

You are currently using env_logger with default features. This includes the regex crate with default features which adds about 1.3MB to a binaries size (see rust-lang/regex#613).

Could you maybe add (and proxy) the features of env_logger so that a consumer of your crate can disable the default features (ie "regex")?

Something along the lines of the following would help:

[features]
default = ["cargo","termcolor", "atty", "humantime", "regex"]
cargo = ["toml"]
termcolor = ["env_logger/termcolor"]
atty = ["env_logger/atty"]
humantime = ["env_logger/humantime"]
regex = ["env_logger/regex"]
@kamek-pf
Copy link
Owner

Apologies, I totally missed the notification on this issue :/
I just released 0.7 which lets you control env_logger's feature flags and disable pretty_env_logger entirely.

Thank you for reporting this !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants