Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the signature of templates cleaner. #107

Merged
merged 1 commit into from Feb 5, 2022
Merged

Make the signature of templates cleaner. #107

merged 1 commit into from Feb 5, 2022

Conversation

kaj
Copy link
Owner

@kaj kaj commented Dec 4, 2021

This is a breaking change.

I hope to enable #88 with this signature change, but that doesn't really seem to happen with the change currently in this PR. So I might try a slightly different signature.

@OskarPersson
Copy link

FYI this also fixes the following Clippy error 🎉

warning: this expression borrows a reference (`&mut W`) that is immediately dereferenced by the compiler
  --> /path/to/file_html.rs:79:15
   |
79 | foo(&mut _ructe_out_)?;
   |     ^^^^^^^^^^^^^^^^ help: change this to: `_ructe_out_`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
$ cargo clippy --version
clippy 0.1.58 (02072b4 2022-01-11)

@vbrandl
Copy link
Contributor

vbrandl commented Feb 1, 2022

Any news on when/if this will be merged? Or a way to suppress the clippy lint mentioned by @OskarPersson ?

@kaj
Copy link
Owner Author

kaj commented Feb 1, 2022

Yes, no ... I'm kind of stuck in #88 , so I haven't decided on this one either. Maybe I should just do something that seems ok here, get a release out and worry about #88 later.

@vbrandl
Copy link
Contributor

vbrandl commented Feb 2, 2022

Would be cool to have this fixed, so CI pipelines with clippy will pass again :)

@kaj kaj merged commit 42ac2f8 into master Feb 5, 2022
@kaj kaj deleted the cleaner-signature branch February 5, 2022 22:04
@kaj kaj mentioned this pull request Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants