Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lifetime support #106

Closed
JojiiOfficial opened this issue Nov 25, 2021 · 2 comments · Fixed by #110
Closed

Lifetime support #106

JojiiOfficial opened this issue Nov 25, 2021 · 2 comments · Fixed by #110

Comments

@JojiiOfficial
Copy link

JojiiOfficial commented Nov 25, 2021 •
edited

Using lifetime annotations (eg @(content: Vec<&'static foo>)) does not work:

warning:    3:@(data: &BaseData, news: Vec<&'static NewsEntry>)
warning:                                  ^ expected ',' or ')'.
@kaj
Copy link
Owner

kaj commented Feb 6, 2022

Ah, I think I parse the ' as a character quote, and thus require matching pairs. Will investigate.

@kaj
Copy link
Owner

kaj commented Feb 6, 2022

I didn't parse the ' character at all. So I have an upcoming fix for at least the 'static lifetime. Will investigate named lifetimes as well.

kaj added a commit that referenced this issue Feb 6, 2022
@kaj
Allow lifetime annotations in type_expression.
afa7a50 
Fixes #106.
@kaj kaj mentioned this issue Feb 6, 2022
Merged
@kaj kaj closed this as completed in #110 Feb 6, 2022
kaj added a commit that referenced this issue Feb 6, 2022
@kaj
Release 0.14.0 - 2022-02-06
05ecb76 
* Breaking change: The generated template functions have a simpler
  signature.
* Allow litetimes in template argument types.  Issue #106, PR #110.
* Improve error handling in optional warp support, PR #109.
* Current stable rust is 1.57, MSRV is now 1.46.0.
* Update nom dependency to 7.1.0.
* Update optional rsass to 0.23.0.
* Update env_logger to 0.9 and gotham to 0.7.1 in examples
* Dropped support for warp 0.2 (the warp02 feature and example).

Thanks to @JojiiOfficial for reporting #106.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow lifetime annotations in type_expression. kaj/ructe
2 participants
@kaj @JojiiOfficial