Tap + Internal Caching Fixes #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds 16.x (latest LTS) to testing suite. xref: tapjs/tapjs#624 The issue is closed, but it is still being reported. xref: nodejs/citgm#852 (comment) This is the fix being used in this commit.
The internal cache really should be caching the generated output of the reduce pattern, not the generated RegExp object, which may not have the right behavior for "ignorecase"
kaelzhang
added a commit
that referenced
this pull request
Nov 3, 2021
kaelzhang
added a commit
that referenced
this pull request
Nov 3, 2021
|
Nice catch, buddy. Landed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error: Cannot find module './reports/base' tapjs/tapjs#624 continues to cause problems for many, and Node.js 16 failures nodejs/citgm#852 (comment) is the only way that seems to resolve it for now.
Add latest LTS (
16.x) to the test suite in GH ActionsInternal
createRegexcache was not respecting theignorecaseparameter to anIgnoreinstance.Fix and test to confirm have been added in this PR.