fix(types): allow for readonly arrays #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for `readonly` arrays in the type definitions.
And there is also a test case for ts cases, so plz also update the cases here |
|
This is relevant for one of my projects as well. I can submit a patch for this as well with a test case if @nicojs doesn't have time. |
|
Cool, I actually was just on my way to submit a patch for this. I'll submit one for just the test-cases then. |
|
Damn, you work fast. OK—thanks for the update! |
kaelzhang
added a commit
that referenced
this pull request
Dec 19, 2021
I happen to be free right now 😄 Landed in |
|
Prefect, just what I needed. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for
readonlyarrays in the type definitions.Fixes #69
Note: this is a draft to illustrate what I mean.