Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests failing as setup-envtest.sh from kubernetes-sigs/controller-runtime now returns a 404 #713

Closed
bradfordcp opened this issue May 1, 2021 · 2 comments · Fixed by #714
Assignees
Labels
bug Something isn't working needs-triage

Comments

@bradfordcp
Copy link
Member

In the GH action run of our unit tests there was a sudden failure.

o fmt ./pkg/...
pkg/cleaner/cleaner.go
pkg/cleaner/cleaner_test.go
go fmt ./tests/...
go vet ./pkg/...
go vet ./tests/...
go test  -test.timeout=3m ./tests/unit/... -coverprofile cover.out
ok  	github.com/k8ssandra/k8ssandra/tests/unit	76.584s	coverage: [no statements]
?   	github.com/k8ssandra/k8ssandra/tests/unit/utils/cassdc	[no test files]
?   	github.com/k8ssandra/k8ssandra/tests/unit/utils/helm	[no test files]
?   	github.com/k8ssandra/k8ssandra/tests/unit/utils/kubeapi	[no test files]
?   	github.com/k8ssandra/k8ssandra/tests/unit/utils/traefik	[no test files]
mkdir -p /home/runner/work/k8ssandra/k8ssandra/testbin
test -f /home/runner/work/k8ssandra/k8ssandra/testbin/setup-envtest.sh || curl -sSLo /home/runner/work/k8ssandra/k8ssandra/testbin/setup-envtest.sh https://raw.githubusercontent.com/kubernetes-sigs/controller-runtime/master/hack/setup-envtest.sh
source /home/runner/work/k8ssandra/k8ssandra/testbin/setup-envtest.sh && fetch_envtest_tools /home/runner/work/k8ssandra/k8ssandra/testbin && setup_envtest_env /home/runner/work/k8ssandra/k8ssandra/testbin && go test  -test.timeout=3m ./pkg/... -coverprofile cover.out
/home/runner/work/k8ssandra/k8ssandra/testbin/setup-envtest.sh: line 1: 404:: command not found
make: *** [Makefile:35: pkg-test] Error 127
Error: Process completed with exit code 2.

Looking at the logic our curl of https://raw.githubusercontent.com/kubernetes-sigs/controller-runtime/master/hack/setup-envtest.sh returns

404: Not Found
@bradfordcp bradfordcp added bug Something isn't working needs-triage labels May 1, 2021
@burmanm burmanm self-assigned this May 2, 2021
@burmanm
Copy link
Contributor

burmanm commented May 2, 2021

controller-runtime decided to remove the script that all operator-sdk test-generators use suddenly 5 days ago.

@burmanm
Copy link
Contributor

burmanm commented May 2, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants