Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying labels for the helm.k0sproject.io/v1beta1 objects #4364

Open
laverya opened this issue May 2, 2024 · 3 comments
Open

Allow specifying labels for the helm.k0sproject.io/v1beta1 objects #4364

laverya opened this issue May 2, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@laverya
Copy link

laverya commented May 2, 2024

Is your feature request related to a problem? Please describe.

Currently, the helmchart objects have one label - k0s.k0sproject.io/stack: helm. It would make it easier for us to backup and restore these objects if we were able to add additional labels to the object.

Describe the solution you would like

There was a top-level field within 'helmextensions' that allowed specifying a set of labels to apply to every chart.

Describe alternatives you've considered

Backing up with the k0s.k0sproject.io/stack: helm label should be possible, but isn't as easy to configure.

Additional context

No response

@laverya laverya added the enhancement New feature or request label May 2, 2024
@twz123
Copy link
Member

twz123 commented May 2, 2024

You can already do arbitrary things with Chart resources if you manage them as plain manifests by placing yaml files into <data-dir>/manifests instead of putting them into the k0s config directly.

@laverya
Copy link
Author

laverya commented May 3, 2024

That would work great if we weren't using Dynamic Configuration! Though I imagine you'd recommend just creating chart objects in the cluster ourselves in that scenario? It would simplify some other logic of ours I suppose

@twz123
Copy link
Member

twz123 commented May 3, 2024

Though I imagine you'd recommend just creating chart objects in the cluster ourselves in that scenario? It would simplify some other logic of ours I suppose

Yes, this is more versatile. The charts specified in the k0s config aren't any special compared to user-managed chart resources. And if you're using dynamic config already, then it's potentially not too hard to reconcile additional chart resources in addition to the k0s cluster config resource, I suppose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants