Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to "join" controllers when external etcd is used #4311

Open
twz123 opened this issue Apr 17, 2024 · 4 comments
Open

Document how to "join" controllers when external etcd is used #4311

twz123 opened this issue Apr 17, 2024 · 4 comments
Labels
area/cli documentation Improvements or additions to documentation
Milestone

Comments

@twz123
Copy link
Member

twz123 commented Apr 17, 2024

When using external etcd, k0s refuses to create controller join tokens:

$ k0s token create --role controller
Error: refusing to create token: cannot join controller into current storage 

This is because join tokens aren't needed in this case. Just spin up another controller with the same config and that's it.

This needs to be documented somewhere, and the CLI error message might be more helpful. It might even include a link to the (not yet existing) documentation for this.

@twz123 twz123 added documentation Improvements or additions to documentation area/cli labels Apr 17, 2024
@twz123
Copy link
Member Author

twz123 commented Apr 17, 2024

As an adjacent observation, k0s allows join tokens for external MySQL or Postgres databases via kine. The situation for those storage types seems to be essentially the same as for external etcd. So I wonder if it would make more sense to simply allow join tokens for external etcd as well, or also refusing to create join tokens for any non-internal-etcd storage.

@jnummelin
Copy link
Collaborator

So I wonder if it would make more sense to simply allow join tokens for external etcd as well

IMO this would make sense

Copy link
Contributor

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label May 22, 2024
@twz123 twz123 added this to the 1.31 milestone May 23, 2024
@twz123 twz123 removed the Stale label May 23, 2024
@jnummelin
Copy link
Collaborator

This is because join tokens aren't needed in this case

They are needed. Through the k0s join api, authorized via the token, the other controllers get the shared CA etc. files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants