Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker node shutdown waits long for containerd-shim #1251

Closed
matti opened this issue Nov 7, 2021 · 12 comments
Closed

worker node shutdown waits long for containerd-shim #1251

matti opened this issue Nov 7, 2021 · 12 comments

Comments

@matti
Copy link

matti commented Nov 7, 2021

waits for containerd-shims:

image

(Ubuntu 20.04, running in proxmox vm, hence the screenshot)

@matti matti added the bug Something isn't working label Nov 7, 2021
@matti matti changed the title worker node shutdown takes long worker node shutdown waits long for containerd-shim Nov 7, 2021
@jnummelin
Copy link
Collaborator

worker node shutdown waits long

How long is long? :) I'd guess it's around 90sec which I remember is the systemd default

@matti
Copy link
Author

matti commented Nov 8, 2021

but from users point of view: I have nothing running, so in my opinion a node should reboot/shut down fast

@jnummelin jnummelin self-assigned this Dec 20, 2021
@jnummelin
Copy link
Collaborator

The root cause is containerd shims not handling SIGTERM properly: containerd/containerd#5502

A fix upstream is targeted for containerd 1.6, there's not much we can do on k0s level before that ships out.

@github-actions
Copy link
Contributor

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Jan 20, 2022
@jnummelin
Copy link
Collaborator

Remove stale, we're still waiting for upstream to have fix for this

@jnummelin jnummelin removed the Stale label Jan 21, 2022
@twz123
Copy link
Member

twz123 commented Feb 10, 2022

The containerd fix has been backported into 1.5.x recently (containerd/containerd#6509), so maybe there'll be a new release soon.

@jnummelin
Copy link
Collaborator

There's now 1.6.0 containerd release which has this fix. We should bump main to use that.

No release yet for 1.5.x that includes this fix.

@github-actions
Copy link
Contributor

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Mar 25, 2022
@matti
Copy link
Author

matti commented Mar 26, 2022

asdf

@twz123
Copy link
Member

twz123 commented Mar 26, 2022

k0s v1.23.5+k0s.0 is out, shipping containerd 1.5.11, which has the fix.

@github-actions github-actions bot removed the Stale label Mar 26, 2022
@github-actions
Copy link
Contributor

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Apr 25, 2022
@twz123
Copy link
Member

twz123 commented Apr 26, 2022

Closing as I believe this is fixed as of v1.23.5+k0s.0. Please ping me if it's not working as intended.

@twz123 twz123 closed this as completed Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants