Read resource settings from environment variables #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings makes the OTel resource effectively the same as resource.Default() with the addition of explicitly setting the service.name
jzelinskie
requested changes
Apr 14, 2022
otel.go
Outdated
| @@ -124,7 +124,7 @@ func OpenTelemetryRunE(flagPrefix string, prerunLevel zerolog.Level) CobraRunFun | |||
| } | |||
|
|
|||
| func initOtelTracer(exporter trace.SpanExporter, serviceName string, propagators []string) error { | |||
| res, _ := resource.New(context.Background(), resource.WithAttributes(semconv.ServiceNameKey.String(serviceName))) | |||
| res, _ := setResource(serviceName) | |||
There was a problem hiding this comment.
This function does return an error. Any reason why we shouldn't propagate it?
jzelinskie
reviewed
Apr 14, 2022
otel.go
Outdated
| @@ -124,7 +124,11 @@ func OpenTelemetryRunE(flagPrefix string, prerunLevel zerolog.Level) CobraRunFun | |||
| } | |||
|
|
|||
| func initOtelTracer(exporter trace.SpanExporter, serviceName string, propagators []string) error { | |||
| res, _ := resource.New(context.Background(), resource.WithAttributes(semconv.ServiceNameKey.String(serviceName))) | |||
| res, err := setResource(serviceName) | |||
|
|
|||
There was a problem hiding this comment.
tiny nitpick: drop this new line
jzelinskie
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings such as
OTEL_RESOURCE_ATTRIBUTESwere not being read in from environment variables. Having this available is important for some automated environments whereOTEL_RESOURCE_ATTRIBUTESis auto-generated from deployment tooling.Note that setting
service.nameinOTEL_RESOURCE_ATTRIBUTESor viaOTEL_SERVICE_NAMEwill still be a no-op because there is a default value set from the command line flags.This also bumps the https://github.com/open-telemetry/opentelemetry-go libraries to the latest stable release. This was required to get it to work with our LightStep environment, although I'm not entirely sure what in the changelog was breaking.
Finally, the https://pkg.go.dev/go.opentelemetry.io/otel/sdk@v1.6.3/resource#WithTelemetrySDK detector was added to inject version information about the OpenTelemetry SDK libraries into span attributes. This is to aid administration of observability services.