Prevent max call stack when merging overlapping keys #483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
merge
function added in #473 expects all keys to be unique across merged objects, otherwise it will trigger a max call stack error as it attempts to merge strings.The merge implementation was intentionally minimal in scope, and an argument could be made for continuing to expect unique keys, but I ran into this issue with a fairly basic use-case – composing
variant
to allow overrides.To help evaluate this PR, I added an additional test which covers this use-case. It is a bit specific so I'm not sure it should land in master as is.