Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving the local development experience #397

Merged
merged 1 commit into from Feb 9, 2021
Merged

Improving the local development experience #397

merged 1 commit into from Feb 9, 2021

Conversation

anakinj
Copy link
Member

@anakinj anakinj commented Dec 25, 2020 •
edited

Yet another PR to improve the development experience for all of us.

Added:

  • Local coverage reports
  • Ruby 3.0 tests on CI
  • Documentation about how to run all different 3rd party combinations using Appraisal
  • Generic rake default task executing RuboCop and the tests.

Removed:

  • Codacy gem dependency, have not seen any reports from there and not sure if we really use it. So just removed it....

yasonk
yasonk approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@yasonk yasonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downloaded the branch and was able to run the tests.
Also don't see any issues with the code

@anakinj
Copy link
Member Author

anakinj commented Feb 6, 2021

Thanks @yasonk for the feedback and reminder, had forgotten all about this. I think I'll take a look at this and merge it later today.

@anakinj anakinj force-pushed the coverage-and-testing branch 2 times, most recently from d6c9dde to df8cc48 Compare February 8, 2021 08:02
@anakinj anakinj merged commit f4925cd into jwt:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasonk yasonk yasonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anakinj @yasonk