Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verifies algorithm before evaluating keyfinder #346

Merged
merged 2 commits into from Jul 7, 2020

Conversation

jb08
Copy link
Contributor

@jb08 jb08 commented Feb 22, 2020

issue 343 PR (coordinated with @zinosama)

@sourcelevel-bot
Copy link

Hello, @jb08! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@jb08 jb08 requested a review from excpt February 22, 2020 15:51
@jb08
Copy link
Contributor Author

jb08 commented Feb 22, 2020

CI failing unrelated to PR, no?

Finished in 1.65 seconds
154 examples, 0 failures
bundler: failed to load command: codeclimate-test-reporter
The command "bundle exec rspec && bundle exec codeclimate-test-reporter" exited with 1.

@jb08
Copy link
Contributor Author

jb08 commented Feb 24, 2020

@ab320012 fyi here is the PR that was discussed as part of issue 343.

@jb08
Copy link
Contributor Author

jb08 commented Feb 27, 2020

cc: @laurawyse @pjo336
getting this merged prior to Peter's ongoing work will save network calls.
(thanks to @zinosama for grooming this work)

@jb08
Copy link
Contributor Author

jb08 commented Mar 10, 2020

@excpt @ab320012 any advice on how to push this forward?

@martinemde
Copy link
Contributor

This looks good to me also. I made a change to the key loader and I'd also like to see this rolled into the next release with both our changes.

See #348

@jb08
Copy link
Contributor Author

jb08 commented Apr 1, 2020

thanks @bdewater for the approval.

@excpt excpt added this to the Version 2.3.0 milestone Jul 7, 2020
@excpt excpt merged commit 53d890d into jwt:master Jul 7, 2020
@excpt excpt modified the milestones: Version 2.3.0, Version 2.2.2 Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants