Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the use of rbnacl to the algorithms openssl actually does not support #550

Open
anakinj opened this issue Feb 2, 2023 · 0 comments
Open

Reduce the use of rbnacl to the algorithms openssl actually does not support #550

anakinj opened this issue Feb 2, 2023 · 0 comments
Milestone
Version 3.x

Comments

@anakinj
Copy link
Member

anakinj commented Feb 2, 2023

To reduce complexity we could stop using rbnacl for the hmac algos after #549 is done.

I think even the openssl hmac algorithms performed faster than the ones in rbnacl (no facts to back this up).
@anakinj anakinj added this to the Version 3.0.0 milestone Feb 2, 2023
anakinj added a commit to anakinj/ruby-jwt that referenced this issue Feb 11, 2023
@anakinj
Reduce dependency to rbnacl fixes jwt#549, jwt#550
d7c2787
anakinj added a commit to anakinj/ruby-jwt that referenced this issue May 7, 2023
@anakinj
Reduce dependency to rbnacl fixes jwt#549, jwt#550
fcb8540
anakinj added a commit to anakinj/ruby-jwt that referenced this issue Dec 17, 2023
@anakinj
Algorithm cleanup.
f1d57ae 
 - Algos module renamed to JWA
 - Standard HMAC algorithms provided explicitly by OpenSSL (jwt#550)
 - Prepare to remove support for the HS512256 algorithm provided by RbNaCl (jwt#549)
@anakinj anakinj mentioned this issue Dec 17, 2023
Merged
2 tasks
anakinj added a commit to anakinj/ruby-jwt that referenced this issue Dec 17, 2023
@anakinj
Algorithm cleanup.
8d2c880 
 - Algos module renamed to JWA
 - Standard HMAC algorithms provided explicitly by OpenSSL (jwt#550)
 - Prepare to remove support for the HS512256 algorithm provided by RbNaCl (jwt#549)
anakinj added a commit to anakinj/ruby-jwt that referenced this issue Dec 17, 2023
@anakinj
Algorithm cleanup.
d589585 
 - Algos module renamed to JWA
 - Standard HMAC algorithms provided explicitly by OpenSSL (jwt#550)
 - Prepare to remove support for the HS512256 algorithm provided by RbNaCl (jwt#549)
anakinj added a commit to anakinj/ruby-jwt that referenced this issue Dec 28, 2023
@anakinj
Algorithm cleanup.
644eda0 
 - Algos module renamed to JWA
 - Standard HMAC algorithms provided explicitly by OpenSSL (jwt#550)
 - Prepare to remove support for the HS512256 algorithm provided by RbNaCl (jwt#549)
anakinj added a commit to anakinj/ruby-jwt that referenced this issue Dec 28, 2023
@anakinj
Algorithm cleanup.
24c7a5b 
 - Algos module renamed to JWA
 - Standard HMAC algorithms provided explicitly by OpenSSL (jwt#550)
 - Prepare to remove support for the HS512256 algorithm provided by RbNaCl (jwt#549)
anakinj added a commit to anakinj/ruby-jwt that referenced this issue Dec 30, 2023
@anakinj
Algorithm cleanup.
5f91246 
 - Algos module renamed to JWA
 - Standard HMAC algorithms provided explicitly by OpenSSL (jwt#550)
 - Prepare to remove support for the HS512256 algorithm provided by RbNaCl (jwt#549)
anakinj added a commit to anakinj/ruby-jwt that referenced this issue Dec 30, 2023
@anakinj
Algorithm cleanup.
2992763 
 - Algos module renamed to JWA
 - Standard HMAC algorithms provided explicitly by OpenSSL (jwt#550)
 - Prepare to remove support for the HS512256 algorithm provided by RbNaCl (jwt#549)
anakinj added a commit to anakinj/ruby-jwt that referenced this issue Jan 29, 2024
@anakinj
Algorithm cleanup.
1d682ff 
 - Algos module renamed to JWA
 - Standard HMAC algorithms provided explicitly by OpenSSL (jwt#550)
 - Prepare to remove support for the HS512256 algorithm provided by RbNaCl (jwt#549)
anakinj added a commit that referenced this issue Feb 17, 2024
@anakinj
Algorithm cleanup.
13dd333 
 - Algos module renamed to JWA
 - Standard HMAC algorithms provided explicitly by OpenSSL (#550)
 - Prepare to remove support for the HS512256 algorithm provided by RbNaCl (#549)
@agrare agrare mentioned this issue Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 3.x
Development

No branches or pull requests
1 participant
@anakinj