Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to install fully specified cmake-version 2.8.12.2 #50

Open
bjosv opened this issue Nov 22, 2022 · 1 comment
Open

Fail to install fully specified cmake-version 2.8.12.2 #50

bjosv opened this issue Nov 22, 2022 · 1 comment

Comments

@bjosv
Copy link

bjosv commented Nov 22, 2022

When requesting a setup of CMake 2.8.12.2 the following error is seen:

Run jwlawson/actions-setup-cmake@v1
  with:
    cmake-version: 2.8.12.2
    github-api-token: ***
    use-32bit: false
Error: Unable to find version matching 2.8.12.2

but when requesting 2.8.12 the installed CMake version is 2.8.12.2 as wanted.
In this case the installed version seems to be preferred over the existing 2.8.12 release, seen in https://cmake.org/files/v2.8/

Is this expected?

I have also noticed that CMakes 2.8.12.1 and 2.8.12.2 releases are some odd animals and might be the only ones that are not following semantic versioning. Would that be the reason for the behavior?

@jwlawson
Copy link
Owner

That's interesting. It seems the node semver module compresses all versions down to the three main versions. In this case it means 2.8.12, 2.8.12.1 and 2.8.12.2 all get converted to version 2.8.12 which is used to do the package selection. This is why if you look for 2.8.12.2 it doesn't get found. If you look for 2.8.12 we pick the first one that matches, which happens to be 2.8.12.2 though that's probably not guaranteed.

I wouldn't say this is expected, just not considered. It definitely comes from the later 2.8.12.x versions not following what node semver expects versions to look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants