Fix handling MacOS universal package #15
Merged
+854
−1,763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwlawson
changed the title
osdeverr
pushed a commit
to osdeverr/actions-setup-re
that referenced
this pull request
Feb 27, 2025
Starting with 3.19.2, cmake provides a universal package for macos with different file names. This requires some slightly different parsing of the asset information to ensure that these new packages are selected correctly. Old package name: cmake-3.16.2-Darwin-x86_64.tar.gz New package name: cmake-3.19.2-macos-universal.tar.gz This also refactors some of the tests that check the areas touched by these changes, making it easier to reproduce these problems locally on different platforms. Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with 3.19.2, cmake provides a universal package for macos with different file names. This requires some slightly different parsing of the asset information to ensure that these new packages are selected correctly.
Old package name: cmake-3.16.2-Darwin-x86_64.tar.gz
New package name: cmake-3.19.2-macos-universal.tar.gz
This also refactors some of the tests that check the areas touched by these changes, making it easier to reproduce these problems locally on different platforms.
Fixes #13