Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DragOver Report Label Captions do not show Translations #408

Open
sschuh opened this issue Sep 19, 2022 · 10 comments
Open

DragOver Report Label Captions do not show Translations #408

sschuh opened this issue Sep 19, 2022 · 10 comments
Assignees
Labels
bug Something isn't working XLIFF XLIFF related feature

Comments

@sschuh
Copy link

sschuh commented Sep 19, 2022

hi,
maybe you have time to optimize this:

image

@jwikman
Copy link
Owner

jwikman commented Sep 19, 2022

Hi @sschuh,

What exactly do you want me to optimize?

The issue template logic seems to have misbehaved when you created the issue. It would help me a lot if you could use below as a template to describe your issue. 🙂

**Describe the bug**
A clear and concise description of what the bug is.

**Versions used**
VSCode:
NAB AL Tools:

**To Reproduce**
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Additional context**
Add any other context about the problem here.

- Does it happen all the time?
- Did it used to work?

I'm sure that we could help you out with the above information!

@jwikman jwikman added the needs more info Issue requires more information from poster label Sep 19, 2022
@jwikman
Copy link
Owner

jwikman commented Sep 19, 2022

@sschuh, Report Labels do show translations OnHover for me, so it must be something else that are messing with your code. Filling out above issue template would help us identify your real issue.

@sschuh
Copy link
Author

sschuh commented Sep 19, 2022

Describe the bug
The OnHover seems not to work in case of report labels.
All other things in the report work fine.

Versions used
VSCode:
Version: 1.71.2 (user setup)
Commit: 74b1f979648cc44d385a2286793c226e611f59e7
Date: 2022-09-14T21:03:37.738Z
Electron: 19.0.12
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Windows_NT x64 10.0.22000
Sandboxed: No

NAB AL Tools:
v1.26.0

To Reproduce
Steps to reproduce the behavior:
Sorry, how can i help you to reproduce it yourself?
Maybe it has something to do with the Report Name itself?
Maybe the screenshots can help.

Expected behavior
The caption(s) from other languages should be shown.

Screenshots
Problem
image

Report
image

G-File
image

DE-de File
image

Additional context

  • Does it happen all the time?
    Yes, in all reports.

@jwikman
Copy link
Owner

jwikman commented Sep 19, 2022

Thanks for the additional information!

Your code and xlf seems perfectly legal, so there must be something fishy going on...

Can you please try to install the pre-release version of NAB AL Tools, v1.27.207261925?

image

There has been some changes done in the parsing of some XLF related stuff, so I just want to be sure that this is not already solved.

@sschuh
Copy link
Author

sschuh commented Sep 19, 2022

I've already tried the Prerelease.
Unfortunately no change.

As additional info:
I work in a workspace.
But, i think, that's not the problem.

Do you have an idea with which information i could support you?

@jwikman
Copy link
Owner

jwikman commented Sep 19, 2022

Ok.

One thing that definitely would give me a chance to fix this, is if you could create a mini project with a repro.

It could consist of only:

  • a report with labels
  • app.json
  • g.xlf file
  • translated xlf file

If you upload that here, and if that reproes for me, we're 90% of the way to a solution. 🙂

@jwikman
Copy link
Owner

jwikman commented Sep 19, 2022

Forgot to say that workspace shouldn't matter...

@jwikman
Copy link
Owner

jwikman commented Sep 19, 2022

Hi again,

I created a small repro app for this. If you unzip this and open in VSCode, do you get the translation OnHover of the label?
ALProject1.zip

Expected result:
image

If you get this to work, but not in your project - there must be something in your AL code and/or xlf file that is messing with our extension.

Please let me know how it goes.

@sschuh
Copy link
Author

sschuh commented Sep 20, 2022

I can reproduce this problem.
image

Attached the modified project:
ALProject1.zip

@jwikman
Copy link
Owner

jwikman commented Sep 20, 2022

That is great, now I can repro as well!

Thanks for the help, I'll get back to you as soon as I had the time to dig into this.

@jwikman jwikman added bug Something isn't working XLIFF XLIFF related feature and removed needs more info Issue requires more information from poster labels Sep 20, 2022
@jwikman jwikman self-assigned this Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working XLIFF XLIFF related feature
Projects
None yet
Development

No branches or pull requests

2 participants