Invalid auto-generated markdown for procedure parameters wrapped in double-quotes

[vody]

Describe the bug
With procedure parameters wrapped in double quotes as in the example below extension generates an invalid markdown.
Code Example:

procedure GuidToUUID("Guid": Guid): Text
begin
    exit(Format("Guid", 0, 4).ToLower())
end;

Autogenerated Markdown:

## <a name="parameters"></a>Parameters

### <a name=""Guid""></a>`"Guid"`  Guid

Versions used
Version: 1.68.1 (user setup)
Commit: 30d9c6cd9483b2cc586687151bcbcd635f373630
Date: 2022-06-14T12:48:58.283Z
Electron: 17.4.7
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Windows_NT x64 10.0.19044
NAB AL Tools: v1.27.207070852

To Reproduce
Steps to reproduce the behavior:

1. Add codeunit with procedure from example which has any parameter wrapped in double-quotes
2. Run a NAB: Generate External Documentation command
3. Open a generated markdown for the newly created procedure
4. See invalid markdown generate for parameters section

Expected behavior
Double-quotes should be removed before the parameter name is used to generate markdown content. Example:

## <a name="parameters"></a>Parameters

### <a name="Guid"></a>`Guid`  Guid

[jwikman]

Hi again @vody, and thanks for reporting this.
We've banned quotes for variables and parameters, and they can easily be workaround just by giving them another name. :)

That being said, I understand that there are old code that you might not be able to change. At least not right now.

I'm not sure that I agree with your suggestion. If it is named with double quotes, why not output that with double quotes? Leaving them out of the anchor name, since otherwise it is invalid.
Like this:

### <a name="Guid"></a>`"Guid"`  Guid

If this should be fixed, scenarios as below should be handled as well.

procedure MyProcedure("A variable with spaces": Guid): Text
begin
    //
end;

it should result in something like this, right?

### <a name="a_variable_with_spaces"></a>`"A variable with spaces"`  Guid

What do you say about that?

[vody]

@jwikman, an issue has been raised as we have a valid AL code and an invalid markdown one. :)
From a procedure usage point of view, the user (developer) will not see a difference if it's double-quoted or not. So don't see any value in keeping double quotes in the documentation. Fully agree that we need to keep spaces and replace spaces with underscores to keep parameter references as straightforward as possible.
Please confirm if you like this approach so I can update my PR accordingly.

[vody]

@jwikman, if we would like to bring this change in, then we may need to apply the same logic for returns.

[jwikman]

@vody I added some comments in the PR :)

I'm fine with removing the " from the output in docs, but when we're at it, we should probably support valid names with double double-quotes inside the names as well.
So a parameter called "Name with ""Quotes""" should be output as Name with "Quotes" in the docs.

Don't you agree?

[vody]

@jwikman, agree. I will try to find some time to redo a PR.

[jwikman]

@vody Just reach out to me or @theschitz if you need any help (or if you just can't find the time for this). However, the time zone difference may cause some response delay... 😁