"Approved" attribute is not supported?

[JSebastianN]

Hello
My external translation tools adds the "Approved" attribute on Trans unit tags.

Example:
trans-unit id="Table 2535081874 - Field 291379351 - Property 2879900210" size-unit="char" translate="yes" xml:space="preserve" approved="yes"

http://docs.oasis-open.org/xliff/v1.2/os/xliff-core.html#approved

However, NAB Tools removes this which changes all the trans unit tags, which makes the whole xlf file a Diff :)

I think NAB tools just need to respect the Approve tag?
At least with setting "UseExternalTranslationTool=true"

[jwikman]

@JSebastianN it seems as if not all external translation tools use this attribute, since I never heard about it before.
But I believe that we should just keep that attribute if it did exist in the first place, regardless of any setting. Don't you agree?

[JSebastianN]

Agree, that would at least help me and would provide backward-compatibility.

I see that t was part of the spec earlier, but I not part of the newest version 2.1
http://docs.oasis-open.org/xliff/xliff-core/v2.1/os/xliff-core-v2.1-os.html
So it is obsolete.

I use Crowdin - I will ask if they would move to setting state=initial/translated/reviewed/final and not the older "Approved"-tag.

[jwikman]

@JSebastianN this is finally released in v1.29.302051950, sorry for the waiting...

[JSebastianN]

Thanks.
Can you give me a hint about the syntax to use here?
"NAB.SearchReplaceBeforeSaveXliff":

[jwikman]

@JSebastianN I just tested the setting myself, and realize that it isn't very intuitive! 😅

I'm actually a bit surprised of how bad VSCode handle these kind of settings.

It is defined as an array with json objects as below

          "NAB.SearchReplaceBeforeSaveXliff": {
            "type": "array",
            "default": [],
            "description": "Specifies if one or more Regular Expression Search & Replace should be performed on the XLF file before it is being saved to disk after being modified by this extension. Eg. this would affect the result after the \"NAB: Refresh XLF files from g.xlf\" has been executed.",
            "items": {
              "description": "Specifies a Regular Expression Search & Replace setting",
              "properties": {
                "searchFor": {
                  "type": "string",
                  "description": "The Regular Expression to search for."
                },
                "replaceWith": {
                  "type": "string",
                  "description": "The replacement text to replace anything that matched the expression defined in \"SearchFor\". Regular Expression Group replacements (like $1) is supported."
                }
              }
            },

That could be translated to this usage:

   "NAB.SearchReplaceBeforeSaveXliff": [
        {
            "searchFor": "></note>",
            "replaceWith": " />"
        },
        {
            "searchFor": ">(.*)\\.</target>",
            "replaceWith": ">$1</target>"
        }
    ]

Intellisense starts to be a help after creating the array and the object
"NAB.SearchReplaceBeforeSaveXliff": [{}]

I hope that helps.